S

Traceback when trying to update node config from Movim

https://bhh.sh/658

This patch suppresses it, but not sure it's correct (and certainly not the "right way"):

diff -r 0b5233981671 sat_pubsub/pgsql_storage.py
--- a/sat_pubsub/pgsql_storage.py       Mon Aug 02 21:58:17 2021 +0200
+++ b/sat_pubsub/pgsql_storage.py       Mon Aug 16 15:08:59 2021 +0000
@@ -549,6 +549,9 @@
             else:
                 cursor.execute("DROP SEQUENCE IF EXISTS {seq_name}".format(seq_name = seq_name))

+    async def dummy(self):
+        return
+
     def setConfiguration(self, options):
         to_delete = []
         for option, value in options.items():
@@ -562,7 +565,7 @@
             del options.fields[option]

         if not options.fields:
-            return
+            return self.dummy()

         if options.get(const.OPT_MAX_ITEMS) == "max":
             # XXX: "max" is default value for config we must convert
G

goffi 28/09/2021, 18:53

The paste is expired, could you put it again? You may paste it directly here, it's important to keep traces for history.

G

goffi 21/10/2021, 16:04

I could reproduce the issue (with a node configuration set without anything to set), thus I believe the traceback is something like: 021-10-21T18:02:52+0200 [-] Unhandled error in iq handler: 2021-10-21T18:02:52+0200 [-] Unhandled Error Traceback (most recent call last): File "/home/goffi/dev/sat_pubsub/sat_pubsub/backend.py", line 764, in <lambda> lambda result: defer.ensureDeferred( File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/internet/defer.py", line 951, in ensureDeferred return Deferred.fromCoroutine(coro) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/internet/defer.py", line 905, in fromCoroutine return _cancellableInlineCallbacks(coro) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/internet/defer.py", line 1571, in _cancellableInlineCallbacks _inlineCallbacks(None, g, status) --- <exception caught here> --- File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/internet/defer.py", line 662, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/wokkel/subprotocols.py", line 449, in fromStanzaError failure.trap(error.StanzaError) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/python/failure.py", line 450, in trap self.raiseException() File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/python/failure.py", line 475, in raiseException raise self.value.with_traceback(self.tb) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/internet/defer.py", line 662, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/wokkel/subprotocols.py", line 445, in checkNotImplemented failure.trap(NotImplementedError) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/python/failure.py", line 450, in trap self.raiseException() File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/python/failure.py", line 475, in raiseException raise self.value.with_traceback(self.tb) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/internet/defer.py", line 662, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/goffi/dev/sat_pubsub/sat_pubsub/backend.py", line 1685, in _mapErrors e = failure.trap(*list(self._errorMap.keys())) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/python/failure.py", line 450, in trap self.raiseException() File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/python/failure.py", line 475, in raiseException raise self.value.with_traceback(self.tb) File "/home/goffi/venvs/sat_pubsub/lib/python3.8/site-packages/twisted/internet/defer.py", line 1445, in _inlineCallbacks result = current_context.run(g.send, result) File "/home/goffi/dev/sat_pubsub/sat_pubsub/backend.py", line 800, in _doSetNodeConfiguration return await node.setConfiguration(options) builtins.TypeError: object NoneType can't be used in 'await' expression

id

391

author

Singpolyma

created

16/08/2021, 15:12

updated

21/10/2021, 16:14

labels
sat_pubsub
type
bug
status
closed
priority
normal
milestone
0.7
severity
normal